Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E / integration test for AdminKubeconfigRequest feature #5586

Closed
timebertt opened this issue Mar 16, 2022 · 5 comments · Fixed by #5938
Closed

E2E / integration test for AdminKubeconfigRequest feature #5586

timebertt opened this issue Mar 16, 2022 · 5 comments · Fixed by #5938
Assignees
Labels
area/testing Testing related kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority)

Comments

@timebertt
Copy link
Member

How to categorize this issue?

/area testing
/kind enhancement

What would you like to be added:

An automated test for the AdminKubeconfigRequest feature. Could be a new e2e test or a step in one of the existing e2e tests or an integration test.

Why is this needed:

AdminKubeconfigRequest was promoted to GA in #5511.
However, there is no automated test for verifying the functionality. Hence, the functionality has to be tested manually in order to prevent bugs and regressions.

@timebertt timebertt added the kind/enhancement Enhancement, improvement, extension label Mar 16, 2022
@gardener-robot gardener-robot added the area/testing Testing related label Mar 16, 2022
@timebertt
Copy link
Member Author

@acumino @petersutter can you take care of adding a test?

@rfranzke
Copy link
Member

From https://github.com/gardener/gardener/blob/master/docs/deployment/getting_started_locally.md#creating-a-shoot-cluster:

⚠️ Please note that in this setup shoot clusters are not accessible by default when you download the kubeconfig and try to communicate with them. The reason is that your host most probably cannot resolve the DNS names of the clusters since provider-local extension runs inside the KinD cluster (see this for more details). Hence, if you want to access the shoot cluster, you have to run the following command which will extend your /etc/hosts file with the required information to make the DNS names resolvable:

How would we overcome this as part of an e2e test?

@timebertt
Copy link
Member Author

In the e2e test, we could workaround this simply looking up the external DNSRecord of the shoot and swap out the hostname in the kubeconfig with the resolved IP address.

@timebertt
Copy link
Member Author

With #5649, shoots/adminkubeconfig was exposed to endusers.
I think, it would be good to add an e2e test for it accordingly.

@timebertt timebertt added priority/2 Priority (lower number equals higher priority) priority/3 Priority (lower number equals higher priority) and removed priority/2 Priority (lower number equals higher priority) labels Apr 4, 2022
@shafeeqes
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Testing related kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants