Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote AdminKubeconfigRequest feature gate to GA #5511

Merged
merged 1 commit into from Mar 8, 2022
Merged

Promote AdminKubeconfigRequest feature gate to GA #5511

merged 1 commit into from Mar 8, 2022

Conversation

acumino
Copy link
Member

@acumino acumino commented Mar 4, 2022

How to categorize this PR?

/area control-plane
/kind enhancement

What this PR does / why we need it:
The AdminKubeconfigRequest feature gate in the gardener-apiserver has been promoted to GA.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The `AdminKubeconfigRequest` feature gate in the `gardener-apiserver` has been promoted to GA.

@acumino acumino requested a review from a team as a code owner March 4, 2022 05:31
@acumino acumino force-pushed the promote/AdminKubeconfigRequest branch from 2441ae9 to b43dbd9 Compare March 4, 2022 06:41
@gardener-robot gardener-robot added area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension labels Mar 4, 2022
@gardener-robot
Copy link

@acumino Thank you for your contribution.

@gardener-robot gardener-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 4, 2022
rfranzke
rfranzke previously approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

ialidzhikov
ialidzhikov reviewed Mar 4, 2022
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/invite @petersutter
as feature gate owner

docs/deployment/feature_gates.md Show resolved Hide resolved
docs/deployment/feature_gates.md Show resolved Hide resolved
@acumino acumino force-pushed the promote/AdminKubeconfigRequest branch from b43dbd9 to b4c1c54 Compare March 4, 2022 09:15
@gardener-robot
Copy link

@acumino You need rebase this pull request with latest master branch. Please check.

@acumino acumino force-pushed the promote/AdminKubeconfigRequest branch from b4c1c54 to b26c009 Compare March 4, 2022 09:19
@acumino acumino force-pushed the promote/AdminKubeconfigRequest branch from b26c009 to 91c7abb Compare March 4, 2022 09:23
@acumino acumino requested a review from ialidzhikov March 4, 2022 09:24
petersutter
petersutter previously approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm, thanks

ialidzhikov
ialidzhikov previously approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, otherwise lgtm

docs/proposals/16-adminkubeconfig-subresource.md Outdated Show resolved Hide resolved
docs/proposals/16-adminkubeconfig-subresource.md Outdated Show resolved Hide resolved
rfranzke
rfranzke previously approved these changes Mar 7, 2022
View reviewed changes
@ialidzhikov ialidzhikov dismissed their stale review March 7, 2022 07:17

approved by accident

@acumino acumino dismissed stale reviews from rfranzke and petersutter via e4c2dde March 8, 2022 06:52
@acumino acumino force-pushed the promote/AdminKubeconfigRequest branch from 91c7abb to e4c2dde Compare March 8, 2022 06:52
ialidzhikov
ialidzhikov approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit 14b8b4f into gardener:master Mar 8, 2022
@timebertt timebertt mentioned this pull request Mar 16, 2022
Closed
krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
@acumino
Promote AdminKubeconfigRequest feature gate to GA (gardener#5511)
234ffce
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
@acumino
Promote AdminKubeconfigRequest feature gate to GA (gardener#5511)
6499e8e
@acumino acumino deleted the promote/AdminKubeconfigRequest branch November 21, 2022 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersutter petersutter petersutter left review comments

@shafeeqes shafeeqes shafeeqes left review comments

@ialidzhikov ialidzhikov ialidzhikov approved these changes

@rfranzke rfranzke rfranzke left review comments

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@acumino @gardener-robot @petersutter @ialidzhikov @rfranzke @shafeeqes @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3