Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[controller-manager] Drop Plant API and controller #6348

Closed
Tracked by #4251
rfranzke opened this issue Jul 18, 2022 · 1 comment · Fixed by #6472
Closed
Tracked by #4251

[controller-manager] Drop Plant API and controller #6348

rfranzke opened this issue Jul 18, 2022 · 1 comment · Fixed by #6472
Assignees
@acumino
Labels
area/dev-productivity Developer productivity related (how to improve development) kind/cleanup Something that is not needed anymore and can be cleaned up

Comments

@rfranzke
Copy link
Member

How to categorize this issue?

/area dev-productivity
/kind cleanup

What would you like to be added:
Let's drop the Plant API and the controller from our codebase.

Why is this needed:
Plants were never used and their overall design is flawed (you can not register clusters which are not accessible from the garden cluster where GCM is running).
@gardener-prow gardener-prow bot added area/dev-productivity Developer productivity related (how to improve development) kind/cleanup Something that is not needed anymore and can be cleaned up labels Jul 18, 2022
This was referenced Jul 19, 2022
Closed
Closed
@grolu grolu mentioned this issue Jul 27, 2022
Closed
@acumino
Copy link
Member

acumino commented Aug 10, 2022

/assign

@acumino acumino mentioned this issue Aug 10, 2022
Merged
istvanballok added a commit to gardener/gardener-metrics-exporter that referenced this issue Aug 18, 2022
@istvanballok @wyb1 @rickardsjp
Remove Plant metrics
9879406 
Motivation: gardener/gardener#6348

Co-authored-by: Wesley Bermbach <wesley.bermbach@sap.com>
Co-authored-by: Istvan Zoltan Ballok <istvan.zoltan.ballok@sap.com>
Co-authored-by: Jeremy Rickards <jeremy.rickards@sap.com>
istvanballok added a commit to gardener/gardener-metrics-exporter that referenced this issue Aug 18, 2022
@istvanballok @wyb1 @rickardsjp
Remove Plant metrics
cc0a9c4 
Motivation: gardener/gardener#6348

Co-authored-by: Wesley Bermbach <wesley.bermbach@sap.com>
Co-authored-by: Istvan Zoltan Ballok <istvan.zoltan.ballok@sap.com>
Co-authored-by: Jeremy Rickards <jeremy.rickards@sap.com>
@istvanballok istvanballok mentioned this issue Aug 18, 2022
Merged
@rfranzke rfranzke changed the title Drop Plant API and controller [controller-manager] Drop Plant API and controller Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acumino acumino

Labels
area/dev-productivity Developer productivity related (how to improve development) kind/cleanup Something that is not needed anymore and can be cleaned up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop Plant API and controller acumino/gardener
2 participants
@rfranzke @acumino