Upgrade k8s.io/* to v0.28, sigs.k8s.io/controller-runtime to v0.16

[shafeeqes]

How to categorize this issue?

/area open-source dev-productivity
/kind enhancement

What would you like to be added:

We should upgrade to the latest versions of our go upstream dependencies:

• sigs.k8s.io/controller-runtime@v0.16.0: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.16.0
• k8s.io/*@v0.28.0: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.28.md
• sigs.k8s.io/controller-tools@v0.13.0: https://github.com/kubernetes-sigs/controller-tools/releases/tag/v0.13.0

Important changes / Action items

Here is a list of a few upstream changes to look out for when vendoring g/g, k/* and c-r in any of our repos (e.g. extensions). Please consider the release notes of controller-runtime@v0.16 and upwards as well for a more complete list and more details.

⚠️ breaking / most notable changes

• Following fields are changed under manager Options :
  • MetricsBindAddress is removed from manager options in favor of Metrics struct. ⚠ Introduce Metrics Options struct & secure metrics serving kubernetes-sigs/controller-runtime#2407
  • Namespace is removed from manager options in favor of cache.DefaultNamespaces. ⚠️ Allow configuring more granular cache filtering kubernetes-sigs/controller-runtime#2421
  • Deprecated fields Port, Host, CertDir, TLSOpts, ClientDisableCacheFor, Namespace and DryRunClient are removed. ⚠ Remove deprecated manager, webhook and cluster options kubernetes-sigs/controller-runtime#2422
• Drop resource lock LeaderElectionResourceLock as the only possible value is lease. Will remove once it is removed from LeaderElectionConfiguration
• Projects which use k8s.io/code-generator and invoke generate-groups or generate-internal-groups.sh have a new, simpler script (kube_codegen.sh) they can use. The old scripts are deprecated but remain intact. (Codegen: a new script for subprojects to use kubernetes/kubernetes#117262) (@ary1992)
  • Drop usage of internal clients, informers and listers #8851
• Use new code-generator script (kube_codegen.sh). Currently the script has few issues [code-generator] Breaking gen_client() function in kube_codegen script kubernetes/kubernetes#121247 due to which it cannot be used in our code-base.
• The new cache.Options.Namespace (replacement for the deprecated MultiNamespacedCacheBuilder) behaves differently when requesting an object in a namespace that is not included in the cache: it simply returns a usual NotFound error. Adapt our FallbackClient accordingly. Enhance fallback client #8447
• Adapt the new restmapper implementation.
  • ⚠️ RESTMapper: don't treat non-existing GroupVersions as errors kubernetes-sigs/controller-runtime#2571, tackled by Upgrade k8s.io/* to v0.29, sigs.k8s.io/controller-runtime to v0.17 #9047

ℹ️ other changes / good to know / for information only:

• ...

[shafeeqes]

To be tackled after #7991

[acumino]

/assign

[acumino]

/unassign
/assign @ary1992

[ary1992]

There were few changes done in the new code-generator which breaks our code generation:

• In new new kube-codegen.sh script, code-gen is called only on type.go file refer. But our apis files are named as type_<api>.go. Hence fix is needed to also include file with names as types_*.go.
  There is already an open PR.
• We are using --extra-peer-dirs at few places for conversion-gen. New kube-codegen.sh doesnot allow the flag anymore. Opened an issue upstream regarding this refer

[ary1992]

Issues related to gen_client function which is breaking us is tracked in the following upstream issue kubernetes/kubernetes#121247

[ary1992]

As the kubernetes code-generator no longer generates client, informers and listers for internal packages, we need to drop using internal clients ,lister and informers. Following PR adapts the changes #8851

[rfranzke]

@ary1992 Could you please update the issue description such that it's visible which takes are still open/what needs to be done? Or do you think it makes more sense to close this one and open a dedicated issue for the left-overs?

[ary1992]

Issues related to gen_client function which is breaking us is tracked in the following upstream issue kubernetes/kubernetes#121247

The issue is fixed with PR kubernetes/kubernetes#121411 and will be shipped with K8s v1.30