Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kube_codegen for some uncovered external cases #121411

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Fix kube_codegen for some uncovered external cases #121411

merged 3 commits into from
Dec 13, 2023

Conversation

thockin
Copy link
Member

@thockin thockin commented Oct 21, 2023 •
edited

/kind bug

Fixes #121247
Replaces #119981

Add a --one-input-api flag

Consumers who want to generate clients into individual directories can use this to process just one API.

It's kind of a hack, but the codegen tools are very rigid and hard to fix.

@ary1992 - can you try this?

NONE

@thockin
kube_codegen: avoid dups in dirs with >1 file
a789a9d 
This happens in out-of-tree consumers of this script.
@thockin
kube_codegen: genclient can look in any Go file
87d158e 
Some out-of-tree consumers have types_foo.go and types_bar.go.
@thockin
kube_codegen: Add a --one-input-api flag
48452fe 
Consumers who want to generate clients into individual directories can
use this to process just one API.

It's kind of a hack, but the codegen tools are very rigid and hard to
fix.
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 21, 2023
This was referenced Oct 21, 2023
Closed
Closed
@k8s-ci-robot k8s-ci-robot added area/code-generation sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2023
@ary1992
Copy link

ary1992 commented Oct 30, 2023

Thank you for the PR @thockin.
The changes are working as expected.

@thockin thockin changed the title WIP: Fix kube_codegen for some uncovered external cases Fix kube_codegen for some uncovered external cases Nov 1, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2023
@thockin
Copy link
Member Author

thockin commented Nov 1, 2023

no longer WIP

@seans3
Copy link
Contributor

seans3 commented Nov 1, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 1, 2023
@liggitt
Copy link
Member

liggitt commented Nov 2, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 53931744af7079388caa17f93873163d0fa34ede

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 4, 2023
@thockin thockin mentioned this pull request Nov 16, 2023
Closed
@k8s-ci-robot k8s-ci-robot merged commit d6fe8db into kubernetes:master Dec 13, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Dec 13, 2023
@ary1992 ary1992 mentioned this pull request Mar 4, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts sttts left review comments

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

[code-generator] Breaking gen_client() function in kube_codegen script
6 participants
@thockin @k8s-ci-robot @ary1992 @seans3 @liggitt @sttts