Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase machine drain and scale down timeouts #1011

Merged
merged 1 commit into from May 15, 2019
Merged

Increase machine drain and scale down timeouts #1011

merged 1 commit into from May 15, 2019

Conversation

prashanth26
Copy link

@prashanth26 prashanth26 commented May 15, 2019 •
edited

What this PR does / why we need it:

  • We see machines on some infrastructures (E.g. Azure) fail to detach data disks attached to a machine in the current drain timeout window of 5mins sometimes leading to machines in a hung state.
  • Machines in the cluster seem to be scaling up and down frequently due to small changes in cluster load.

Which issue(s) this PR fixes:
Fixes #1010

Special notes for your reviewer:

  • The maximum time taken to drain a node has been updated from 5mins to 20mins
  • Scale down before removing an underutilized node has been updated from 10mins to 30mins
  • Scale down after adding of a node is only possible after 60mins

Release note:

Increased machine drain and scale down timeouts

@prashanth26
Increased drain and scale down timeouts
4e249cc 
- Maximum time taken to drain a node has been updated from 5mins to 20mins
- Scale down before removing an under utilized node has been updated from 10mins to 30mins
- Scale down after adding of node is only possible after 60mins
@prashanth26 prashanth26 requested a review from a team as a code owner May 15, 2019 10:13
rfranzke
rfranzke approved these changes May 15, 2019
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit 87abf0a into gardener:master May 15, 2019
rfranzke added a commit to gardener-attic/gardener-extensions that referenced this pull request May 28, 2019
@rfranzke
Update machine-controller-manager settings (see gardener/gardener#1011)
153ddcd
@prashanth26 prashanth26 deleted the enhancement/update-timeouts branch April 20, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase machine drain and scale down timeouts
3 participants
@prashanth26 @rfranzke @gardener-robot-ci-1