Fix health check library predicate & LastTransitionTime #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it is a bug which you want to cherry-pick on extension, then don't rebase it on PR which is not merged in g/g. |
|
@ialidzhikov it is not based on this PR I was mentioning in the description. It was only a hint for reviewers that, if the mentioned PR is merged, this PR has to be rebased. I removed the comment as I see it is confusing. |
rfranzke
reviewed
May 11, 2020
|
/kind/bug |
ghost
added
the
ialidzhikov
reviewed
May 11, 2020
danielfoehrKn
force-pushed
the
quality/healthcheck-too-frequent-reconcile
branch
from
ed1a6a1
to
1677870
Compare
rfranzke
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There was a regression introduced with my previous PR not discover during testing.
This leads to too many reconciles when the Extension.status is updated.
Also fixes the health check condition LastTransition time.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: