New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-v1.5] Fix deletion case for extension predicates #2445
Conversation
Maybe I missed it, but why isn't it a 1:1 backport of #2435? This is a different commit now? |
@rfranzke I think this is the "safer" version (only adding a predicate to make the deletion case working) from there. |
Well, that's exactly what we discussed here after the suggestion from @ialidzhikov and your response. |
I see, probably I missed this point, sorry. I'm fine with this PR if you think it makes more sense, but why can't we simply take the same fix that we did for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/ok-to-test
@rfranzke I have no strong opinion but know it was confusing to apply a different fix as a back port because it looked differently. Now, I applied the exact same changes we had applied to the |
Thanks Tim! |
How to categorize this PR?
/area quality
/kind bug
/priority normal
What this PR does / why we need it:
This PR fixes the deletion of shoots or their extension resources in the seed once shoots were in a
Failed
state.Special notes for your reviewer:
Release note: