Increase default QPS for Seed Clients #2567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/quality
gardener-robot
added
priority/3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area quality
/kind enhancement
/priority normal
What this PR does / why we need it:
This PR increases the default QPS value for Seed Clients.
Bevor my refactoring in #2449, every Shoot operation created its own Seed client, so the configured QPS setting in the GardenletConfiguration was actually applied only to each individual Seed client (per Shoot operation). That in turn means, that in sum the maximum QPS was actually not respected when talking to the Seed's API server.
This is a problem when many Shoot's are created in parallel and the gardenlet sends a lot of requests to the Seed's API server.
Which issue(s) this PR fixes:
Special notes for your reviewer:
/invite @ialidzhikov
/cc @zanetworker
Release note: