Fix skipped charts in check-charts #2584
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area dev-productivity
/area quality
/kind bug
/priority normal
What this PR does / why we need it:
Previously,
hack/check-charts.sh
was only checking charts one level under the given directory (./charts
for g/g).This led to many charts not being checked, that are contained in other directories for structuring (e.g.
seed-dns/{entry,provider}
or the charts underseed-controlplane
).This PR fixes this behaviour, so that all "top-level" charts will be checked from now on.
It also adds the possibility to add test values in
values-test.yaml
to the chart directories which will be merged into the defaultvalues.yaml
. This is useful, if you want to check charts that have a{{ required ... }}
statement, but don't want to specify default values.Checked previously:
Checked now:
Which issue(s) this PR fixes:
Ref #2580
Ref #2471 (comment)
Special notes for your reviewer:
/invite @swilen-iwanow
Release note: