Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skipped charts in check-charts #2584

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

timebertt
Copy link
Member

How to categorize this PR?

/area dev-productivity
/area quality
/kind bug
/priority normal

What this PR does / why we need it:
Previously, hack/check-charts.sh was only checking charts one level under the given directory (./charts for g/g).
This led to many charts not being checked, that are contained in other directories for structuring (e.g. seed-dns/{entry,provider} or the charts under seed-controlplane).

This PR fixes this behaviour, so that all "top-level" charts will be checked from now on.
It also adds the possibility to add test values in values-test.yaml to the chart directories which will be merged into the default values.yaml. This is useful, if you want to check charts that have a {{ required ... }} statement, but don't want to specify default values.

Checked previously:

charts/cluster-identity
charts/global-network-policies
charts/seed-bootstrap
charts/seed-monitoring
charts/shoot-addons-kyma
charts/shoot-addons
charts/shoot-cloud-config-rbac
charts/shoot-cloud-config
charts/utils-templates
charts/utils-tls-cipher-suites

Checked now:

charts/cluster-identity
charts/garden-project/charts/project-rbac
charts/gardener/controlplane
charts/gardener/gardenlet
charts/global-network-policies
charts/istio/istio-crds
charts/istio/istio-ingress
charts/istio/istio-istiod
charts/istio/istio-proxy-protocol
charts/seed-bootstrap
charts/seed-controlplane/charts/cluster-autoscaler
charts/seed-controlplane/charts/etcd
charts/seed-controlplane/charts/gardener-resource-manager
charts/seed-controlplane/charts/kube-apiserver
charts/seed-controlplane/charts/kube-apiserver-service
charts/seed-controlplane/charts/kube-apiserver-sni
charts/seed-controlplane/charts/kube-controller-manager
charts/seed-controlplane/charts/kube-scheduler
charts/seed-controlplane/charts/network-policies
charts/seed-dns/entry
charts/seed-dns/provider
charts/seed-monitoring
charts/seed-operatingsystemconfig/downloader
charts/seed-operatingsystemconfig/original
charts/shoot-addons
charts/shoot-addons-kyma
charts/shoot-cloud-config
charts/shoot-cloud-config-rbac
charts/shoot-core/components
charts/shoot-core/namespaces
charts/utils-templates
charts/utils-tls-cipher-suites

Which issue(s) this PR fixes:
Ref #2580
Ref #2471 (comment)

Special notes for your reviewer:
/invite @swilen-iwanow

Release note:

It is possible now to add a `values-test.yaml` file to helm charts to specify default values for chart checks, which will be merged into the default `values.yaml` when running `hack/check-charts.sh`. This is useful for the case, that charts have a `{{ required ... }}` statement, but don't specify default values in `values.yaml`.

@timebertt timebertt requested a review from a team as a code owner July 14, 2020 08:04
@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug needs/review labels Jul 14, 2020
Copy link
Contributor

@swilen-iwanow swilen-iwanow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested it with my PR. works gr8. thanks!

Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@timebertt timebertt merged commit e05ebb4 into gardener:master Jul 14, 2020
@timebertt timebertt deleted the fix/check-charts branch July 14, 2020 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev-productivity Developer productivity related (how to improve development) area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants