Use DirectClient to wait for OSC #2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/quality
timuthy
approved these changes
Jul 15, 2020
danielfoehrKn
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area quality
/kind bug
/priority normal
What this PR does / why we need it:
When adapting the gardenlet's seed client usage in f120f2c, I missed one usage of
common.WaitUntilExtensionCRReadyinapplyAndWaitForShootOperatingSystemConfig, which should have also been switched to theDirectClient.Therefore, the
cloud-configscript in the Shoot was not properly updated after some change in the worker config or similar in case theCachedRuntimeClientsfeature gate was activated. In that case, only after a second reconciliation the secret was updated correctly.This PR fixes this bug.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/cc @zanetworker
Release note: