Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait worker to be ready before nginx LB #2599

Merged
merged 1 commit into from
Jul 17, 2020

Conversation

vpnachev
Copy link
Member

@vpnachev vpnachev commented Jul 17, 2020

How to categorize this PR?

/area quality
/kind bug
/priority normal

What this PR does / why we need it:
The check for public IP of the ingress LB now depends on worker to be ready.

Which issue(s) this PR fixes:
Fixes #2598

Special notes for your reviewer:

Release note:

Fix a bug where creation of a shoot with ingress addon might fail because of still not created worker.

@vpnachev vpnachev requested a review from a team as a code owner July 17, 2020 11:17
@gardener-robot gardener-robot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug priority/normal labels Jul 17, 2020
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@timuthy timuthy merged commit 876dd80 into gardener:master Jul 17, 2020
@vpnachev vpnachev deleted the ingress/wait-worker-ready branch July 17, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shoot failed to be created waiting ingress LB to be ready
6 participants