Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scale down VPA on shoot hibernation #2606

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Scale down VPA on shoot hibernation #2606

merged 1 commit into from
Jul 20, 2020

Conversation

rfranzke
Copy link
Member

How to categorize this PR?

/area auto-scaling
/kind bug
/priority normal

What this PR does / why we need it:
The VPA components for the shoots weren't scaled down on hibernation. This PR fixes the behaviour.
Also, a nil pointer exception that occurred when a new shoot was created with VPA=enabled has been fixed.

Thanks @wyb1 for noticing!

Release note:

The VPA for shoots running in the seed is now correctly scaled down when the shoot is being hibernated.

@rfranzke rfranzke requested a review from a team as a code owner July 20, 2020 10:48
@gardener-robot gardener-robot added area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related kind/bug Bug priority/normal labels Jul 20, 2020
wyb1
wyb1 approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@wyb1 wyb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! /lgtm

timuthy
timuthy approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit 28a0994 into gardener:master Jul 20, 2020
@rfranzke rfranzke deleted the fix/scale-down-vpa-on-hibernation branch July 20, 2020 16:15
@vpnachev vpnachev mentioned this pull request Jul 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyb1 wyb1 wyb1 approved these changes

@timuthy timuthy timuthy approved these changes

Assignees
No one assigned
Labels
area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related kind/bug Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rfranzke @wyb1 @timuthy @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot