Fix health manager #2609
Merged
Fix health manager #2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/quality
|
/invite @rfranzke |
rfranzke
approved these changes
Jul 21, 2020
| }) | ||
|
|
||
| Describe("#Get", func() { | ||
| It("should get the correct status (true)", func() { | ||
| d.health = true | ||
| Expect(d.health).To(BeTrue()) | ||
| Expect(d.Get()).To(BeTrue()) |
vpnachev
approved these changes
Jul 21, 2020
|
@vpnachev In the tests for the I think we can go ahead with the /merge. |
This was referenced Jul 22, 2020
gardener-robot
added
priority/3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area quality
/area robustness
/kind bug
/priority normal
What this PR does / why we need it:
The periodic health manager seemed to be unstable under CPU pressure/throttling (e.g. in our CI pipelines https://concourse.ci.gardener.cloud/teams/gardener/pipelines/gardener-master/jobs/master-pull-request-job/builds/17).
While I couldn't get the failing unit tests to break on my machine, it was easy to reproduce while running in a docker container with restricted CPU shares.
This PR makes the health manager(s) more robust for concurrent access by accurately locking access to the managers' state members.
Which issue(s) this PR fixes:
Ref #2532
Special notes for your reviewer:
Release note: