Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ControllerInstallation required calculation #2610

Merged
merged 2 commits into from
Jul 22, 2020
Merged

Fix ControllerInstallation required calculation #2610

merged 2 commits into from
Jul 22, 2020

Conversation

timuthy
Copy link
Contributor

@timuthy timuthy commented Jul 21, 2020 •
edited by ialidzhikov

How to categorize this PR?

/area robustness
/kind bug
/priority normal

What this PR does / why we need it:
This PR fixes the calculation of ControllerInstallations. Earlier ControllerInstallations were still considered as required even though no corresponding extension resources or Shoot clusters existed. Please look at #2519 for more information.

We also added the validation for known extension kinds in ControllerRegistrations along the way.

Thanks to @rfranzke for collaborating on this PR.

Which issue(s) this PR fixes:
Fixes #2519 #2572

Release note:

An issue has been fixed which prevented not required ControllerInstallations from being deleted. As a side effect, it also blocked the deletion of Seed resources.

Gardener now validates the extension kinds configured in `.spec.resources[].kind` in ControllerRegistrations.

@timuthy timuthy requested a review from a team as a code owner July 21, 2020 14:26
@gardener-robot gardener-robot added area/robustness Robustness, reliability, resilience related priority/normal labels Jul 21, 2020
@gardener gardener deleted a comment from gardener-robot Jul 21, 2020
rfranzke
rfranzke previously approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/needs second-opinion

@gardener-robot
Copy link

@timuthy The pull request was assigned to you under author-action. Please unassign yourself when you are done. Thank you.

timuthy and others added 2 commits July 22, 2020 08:03
@timuthy @rfranzke
Add validation for extension kinds
4eb6cd7 
Co-authored-by: Rafael Franzke <rafael.franzke@sap.com>
@timuthy @rfranzke
Fix required decision for ControllerInstallations
77b11c3 
Co-authored-by: Rafael Franzke <rafael.franzke@sap.com>
@timuthy timuthy force-pushed the fix.controller-installation branch from 0f83a91 to 77b11c3 Compare July 22, 2020 06:04
@timuthy timuthy changed the title Fix.controller installation Fix ControllerInstallation required calculation Jul 22, 2020
@timuthy timuthy removed their assignment Jul 22, 2020
@rfranzke rfranzke self-assigned this Jul 22, 2020
rfranzke
rfranzke approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke requested a review from vpnachev July 22, 2020 06:28
vpnachev
vpnachev approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit 260d955 into gardener:master Jul 22, 2020
@timuthy timuthy deleted the fix.controller-installation branch July 22, 2020 08:57
@ialidzhikov ialidzhikov mentioned this pull request Jul 22, 2020
Closed
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpnachev vpnachev vpnachev approved these changes

@rfranzke rfranzke rfranzke approved these changes

Assignees

@rfranzke rfranzke

Labels
area/robustness Robustness, reliability, resilience related kind/bug Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Last responsible extension controller remains on seed after getting obsolete
6 participants
@timuthy @gardener-robot @vpnachev @rfranzke @gardener-robot-ci-1 @gardener-robot-ci-2