-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added machineclasses CRD for out-of-tree machine controllers #2625
added machineclasses CRD for out-of-tree machine controllers #2625
Conversation
cc @prashanth26 |
Hi @MartinWeindel , Thanks for the quick change. Also this might not be needed right? - https://github.com/gardener/gardener/blob/f12bb20a834bd14221f8d9a8f36dd70de7d2aa47/extensions/pkg/controller/worker/machine_crds.go#L196-L333. If it's not required, we could remove this as well? |
Wouldn't it be better to keep the old machine classes as long as there are still providers with in-tree machine controllers? |
/invite @prashanth26 @hardikdr |
Sorry, you are right. I mistook this change to be on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks.
f12bb20
to
2b3cf68
Compare
updated description text for provider field as suggested by @prashanth26 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
How to categorize this PR?
/area control-plane
/kind enhancement
/priority normal
What this PR does / why we need it:
The CRD of the generic machineclass used by all out-of-tree machine controllers is added to the well-known list of machine CRDs. This avoids that every infrastructure provider using OOT MCM has to deploy it explicitly.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: