Don't redeploy worker on Shoot deletion #2626
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area quality
/area robustness
/kind bug
/priority normal
What this PR does / why we need it:
We have seen some issues with the
DeployWorker
step during Shoot deletion, e.g. sometimes the Worker was redeployed in a new run of the deletion flow, although it had already been deleted in a previous run. This sometimes caused resources to leak, that the Worker extension deployed.The redeployment in the deletion flow was originally introduced to ensure, updated provider credentials were transported to MCM. In the meantime, the generic worker actuator was enhanced to redeploy
MachineClasses
on Worker deletion and by this also update the provider credentials (ref gardener-attic/gardener-extensions#606).This PR removes the Worker redeployment in the Shoot deletion flow, because it is not needed anymore and rather might cause issues.
Which issue(s) this PR fixes:
Fixes #2453 (hopefully)
Special notes for your reviewer:
I tested the following scenarios and all worked:
Release note: