Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't redeploy worker on Shoot deletion #2626

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

timebertt
Copy link
Member

How to categorize this PR?

/area quality
/area robustness
/kind bug
/priority normal

What this PR does / why we need it:
We have seen some issues with the DeployWorker step during Shoot deletion, e.g. sometimes the Worker was redeployed in a new run of the deletion flow, although it had already been deleted in a previous run. This sometimes caused resources to leak, that the Worker extension deployed.
The redeployment in the deletion flow was originally introduced to ensure, updated provider credentials were transported to MCM. In the meantime, the generic worker actuator was enhanced to redeploy MachineClasses on Worker deletion and by this also update the provider credentials (ref gardener-attic/gardener-extensions#606).

This PR removes the Worker redeployment in the Shoot deletion flow, because it is not needed anymore and rather might cause issues.

Which issue(s) this PR fixes:
Fixes #2453 (hopefully)

Special notes for your reviewer:

I tested the following scenarios and all worked:

  • delete a Shoot with valid credentials
  • delete a hibernated Shoot with valid credentials
  • delete a Shoot with invalid credentials, update the credentials to valid ones after deletion failure and see it being deleted successfully
  • delete a hibernated Shoot with invalid credentials, update the credentials to valid ones after deletion failure and see it being deleted successfully

Release note:

During deletion of a Shoot, the `gardenlet` does not redeploy the `Worker` extension resource anymore, as this sometimes caused leaking resources that blocked the deletion of the Shoot's namespace.

@timebertt timebertt requested a review from a team as a code owner July 24, 2020 08:30
@gardener-robot gardener-robot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related area/robustness Robustness, reliability, resilience related kind/bug Bug priority/normal labels Jul 24, 2020
@rfranzke rfranzke self-assigned this Jul 24, 2020
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for your extensive tests!

@timuthy timuthy merged commit 20c4f58 into gardener:master Jul 27, 2020
@timebertt timebertt deleted the fix/dont-redeploy-worker branch December 1, 2020 14:34
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related area/robustness Robustness, reliability, resilience related kind/bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generic worker actuator leaves orphaned MCM resources when deleting shoots
6 participants