Prevent seed-boostrap to delete Shoot VPA RBAC #2639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area auto-scaling
/kind bug
/priority normal
What this PR does / why we need it:
Currently for a Shoot cluster which is registered as Seed, the seed controller wrongly deletes VPA RBAC from the cluster when the Shoot has
spec.kubernetes.verticalPodAutoscaler.enabled=true
and the corresponding Seed hasspec.settings.verticalPodAutoscaler.enabled=false
.The Shoot cluster SystemComponentsHealthy is constantly flapping (caused by the 2 control loops acting on the same resource - seed controller deleting it and gardener-resource-manager creating it):
This PR adds the cluster type (shoot or seed) as part of the VPA RBAC name and in this way prevents the issue.
Release note: