Secret generation waits for kube-apiserver LB if shoot DNS disabled #2643
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area networking
/kind bug
/priority normal
What this PR does / why we need it:
With #2359 the
DeploySecrets
function is no longer generating the secret, but theGenerateAndSaveSecrets
function does. Hence, this task needs to depend on the "wait for kube-apiserver service to be ready task" in case the shoot DNS is disabled for the particular seed.Special notes for your reviewer:
Thanks @mkoynov for reporting the bug!
Release note: