Use goimports for formatting #2655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/dev-productivity
dguendisch
requested changes
Aug 3, 2020
timebertt
force-pushed
the
hack/goimports
branch
from
d4d242a
to
0fc0989
Compare
dguendisch
approved these changes
Aug 3, 2020
schrodit
approved these changes
Aug 3, 2020
rfranzke
approved these changes
Aug 3, 2020
I don't like it either. Totally agreed 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area dev-productivity
/kind task
/priority normal
What this PR does / why we need it:
Following up on discussions like #2336 (comment), this PR switches formatting to goimports, in order to get rid of
please sort the importscomments on PRs.Unfortunately, goimports also does not correctly group all third-party/local imports into one import group according to https://github.com/golang/go/wiki/CodeReviewComments#imports.
But as discussed in the linked thread, it probably makes sense to stick to official tools like goimports and agree on the formatting enforced by it, so we can just omit PR comments like
please sort the importsif goimports accepts the proposed sorting.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: