Add utility function to refresh shoot webhook netpols #2663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/networking
vpnachev
reviewed
Aug 4, 2020
extensions/pkg/controller/controlplane/genericactuator/actuator.go
Outdated
Show resolved
Hide resolved
|
/status author-action |
|
@rfranzke The pull request was assigned to you under |
rfranzke
force-pushed
the
fix/extensions-shootwebhook-netpol
branch
from
10b59e5
to
020a8b2
Compare
timuthy
requested changes
Aug 5, 2020
extensions/pkg/controller/controlplane/genericactuator/actuator.go
Outdated
Show resolved
Hide resolved
rfranzke
force-pushed
the
fix/extensions-shootwebhook-netpol
branch
from
020a8b2
to
5ad64cd
Compare
stoyanr
reviewed
Aug 5, 2020
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area networking
/kind bug
/priority normal
What this PR does / why we need it:
A utility function that reconciles the shoot webhook configurations has been added to the generic
ControlPlaneactuator package. It is recommended for all extensions that have shoot webhooks to call this function before starting the control loops to ensure that the webhook configurations are updated in case the ports change.Special notes for your reviewer:
/cc @timebertt @stoyanr
Release note: