-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase leader election settings for shoot's GRM #2667
Increase leader election settings for shoot's GRM #2667
Conversation
/invite @zanetworker @wyb1 @istvanballok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
bd82b34
to
17ab9cc
Compare
/ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
WDYT about adding a release note, that the grm LE config is changed now and CM updates should be reduced now?
@timebertt I didn't add one on purpose as I wasn't sure how this information is helpful to an operator/admin, or? It's rather an internal detail, isn't it? |
As you like :) |
OK, I've added a small note now. |
How to categorize this PR?
/area cost networking robustness
/kind enhancement
/priority normal
What this PR does / why we need it:
We run one GRM per shoot control plane, and the GRM is doing its leader election via configmaps in the seed - by default every
2s
. This can lead to a lot ofPUT /v1/configmaps
requests on the API server, and given that a seed is very busy anyways, we should not unnecessarily stress the API server with this leader election. The GRM's sync period is1m
anyways, so it doesn't matter too much if the leadership determination may take up to one minute.Which issue(s) this PR fixes:
Part of #1953
Special notes for your reviewer:
✅ Depends on gardener-attic/gardener-resource-manager#72 and a new release.
/invite @timebertt @vlerenc
Release note: