Creates new objects every time artifact.newFunc is called #2679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/control-plane
timuthy
approved these changes
Aug 7, 2020
|
Created 3 clusters locally successfully without additional data in the shootstates. |
|
Yes, please. Actually, this test should be independent of the control plane migration but be a dedicated integration test for the shoot state controller. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind bug
/priority blocker
What this PR does / why we need it:
This PR makes it so that
artifact.newFuncwill return a new object every time it is called instead of reusing the same object per extension resource kind or controllerinstallation kind.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Release note: