Always allow project owner to be added to member list when creating a new project #2699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/quality
gardener-robot
added
exp/intermediate
platform/all
size/XS
|
/assign |
|
/hold just to be sure that it really works as intended (will do some more testing locally) |
rfranzke
force-pushed
the
fix/project-creation
branch
from
189166d
to
314d8a6
Compare
|
/unhold I've updated the PR to also reflect that if the user submitting the admission request is the owner of the project then the authorization check will be bypassed as the owner has full UAM privileges anyways (i.e., it will be anyways bound to the PS: This whole project management is a very nice case for a new integration test... ref #1564. |
gardener-robot
added
needs/review
size/S
gardener-robot
removed
the
size/XS
gardener-robot
added
priority/3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area quality
/kind bug
/priority normal
/topology garden
/exp intermediate
/size s
/platform all
What this PR does / why we need it:
After #2611 the
Projectcreation is broken as the owner is automatically added by the Gardener API server to the.spec.members[]list, however, this was not handled specially and thus always rejected.Special notes for your reviewer:
/invite @vpnachev
/assign @vpnachev
Release note: