Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove experimental Kyma addon #2701

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Remove experimental Kyma addon #2701

merged 1 commit into from
Aug 11, 2020

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Aug 10, 2020 •
edited

How to categorize this PR?

/area open-source
/kind cleanup
/priority normal

What this PR does / why we need it:
With this PR we remove the experimental Kyma addon again from Gardener as it was only added temporarily with #1754 and supposed to being removed again in the future. This future is now.

Special notes for your reviewer:
/assign @a-thaler

Release note:

The experimental Kyma addon has been removed from Gardener, i.e., the setting `experimental.addons.shoot.gardener.cloud/kyma` annotation has no effect anymore. Existing Kyma installations will remain deployed/untouched.

@rfranzke rfranzke requested a review from a team as a code owner August 10, 2020 13:39
@gardener-robot
Copy link

@rfranzke Command "/invite @a-thaler " failed with "Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the gardener/gardener repository.".

Additional Information 
Redacted in public. Check backend logs.

@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/cleanup Something that is not needed anymore and can be cleaned up needs/review labels Aug 10, 2020
timebertt
timebertt approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vpnachev
Copy link
Member

@gardener/dashboard-maintainers you could disable the Kyma addon when running with Gardener version is >=v1.9.0

vpnachev
vpnachev approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ialidzhikov ialidzhikov merged commit fb6e4f6 into gardener:master Aug 11, 2020
@rfranzke rfranzke deleted the cleanup/remove-kyma branch August 11, 2020 06:49
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpnachev vpnachev vpnachev approved these changes

@a-thaler a-thaler a-thaler approved these changes

@timebertt timebertt timebertt approved these changes

Assignees
No one assigned
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/cleanup Something that is not needed anymore and can be cleaned up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@rfranzke @gardener-robot @vpnachev @a-thaler @timebertt @ialidzhikov @gardener-robot-ci-2 @gardener-robot-ci-3