Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrent map writes #2708

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Aug 11, 2020

How to categorize this PR?

/area robustness
/kind bug
/priority normal

What this PR does / why we need it:
This PR fixes a concurrent map writes issue in Gardenlet.

Which issue(s) this PR fixes:
Fixes #2697

Special notes for your reviewer:
/cc @timebertt

Release note:

An issues has been fixed which caused the Gardenlet to exit ungracefully during the shoot reconciliation.

Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@timuthy timuthy merged commit 46865f2 into gardener:master Aug 11, 2020
@timuthy timuthy deleted the fix.concurrent-map-write branch August 11, 2020 10:43
@timebertt
Copy link
Member

Nice finding @timuthy!
I couldn't figure it out, but now that you solved it, it makes perfect sense :)

@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/robustness Robustness, reliability, resilience related kind/bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gardenlet crashed with concurrent map writes
8 participants