Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase resource requests for fluent-bit #2723

Merged

Conversation

vpnachev
Copy link
Member

@vpnachev vpnachev commented Aug 12, 2020

How to categorize this PR?

/area logging
/kind enhancement
/priority normal

What this PR does / why we need it:
Increase resource requests for fluent-bit

On large landscapes with large seed nodes the fluent bit is handling a lot more logs. With this change its requests are closer to the real usage so it can have more guaranteed resources.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/invite @vlvasilev @Kristian-ZH
/assign @vlvasilev @Kristian-ZH

Release note:

The resource requests for the `fluent-bit` DaemonSet running in the seed clusters have been increased.

Kristian-ZH
Kristian-ZH previously approved these changes Aug 13, 2020
Copy link
Contributor

@Kristian-ZH Kristian-ZH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my setup it is even 200m CPU and 200Mi memory but it is also OK

vlvasilev
vlvasilev previously approved these changes Aug 13, 2020
Copy link
Contributor

@vlvasilev vlvasilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

rfranzke
rfranzke previously approved these changes Aug 13, 2020
@rfranzke
Copy link
Member

/needs rebase
/status author-action

@gardener-robot
Copy link

@vpnachev The pull request was assigned to you under author-action. Please unassign yourself when you are done. Thank you.

@vpnachev
Copy link
Member Author

vpnachev commented Aug 13, 2020

/remove status/author-action
/remove needs/rebase

/needs review

@vpnachev vpnachev merged commit c6e4c8f into gardener:master Aug 13, 2020
@vpnachev vpnachev deleted the logging/increase-fluentbit-requests branch August 13, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logging Logging related kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants