Add monitoring for API Server Watches #2743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/monitoring
|
/invite @timebertt |
|
Thank you very much for the PR! |
timebertt
reviewed
Aug 20, 2020
charts/seed-monitoring/charts/core/charts/prometheus/rules/kube-apiserver.rules.yaml
Outdated
Show resolved
Hide resolved
charts/seed-monitoring/charts/grafana/dashboards/operators/apiserver-watches-dashboard.json
Outdated
Show resolved
Hide resolved
charts/seed-monitoring/charts/grafana/dashboards/operators/apiserver-watches-dashboard.json
Outdated
Show resolved
Hide resolved
charts/seed-monitoring/charts/grafana/dashboards/operators/apiserver-watches-dashboard.json
Outdated
Show resolved
Hide resolved
charts/seed-monitoring/charts/grafana/dashboards/operators/apiserver-watches-dashboard.json
Outdated
Show resolved
Hide resolved
charts/seed-monitoring/charts/core/charts/prometheus/rules/kube-apiserver.rules.yaml
Outdated
Show resolved
Hide resolved
timebertt
reviewed
Aug 20, 2020
charts/seed-monitoring/charts/grafana/dashboards/operators/apiserver-watches-dashboard.json
Outdated
Show resolved
Hide resolved
wyb1
force-pushed
the
add-apiserver-watch-metrics
branch
from
574fb90
to
d2c0bd3
Compare
wyb1
force-pushed
the
add-apiserver-watch-metrics
branch
from
d2c0bd3
to
e8460f6
Compare
|
Thanks for the review @timebertt! I've addressed the comments. PTAL |
timebertt
previously approved these changes
Aug 20, 2020
|
/retest |
|
@timebertt Command |
|
/ok-to-test |
* Add metric shoot:apiserver_watch_duration:quantile * Add dashboard to show length of API Server watches based on resource
wyb1
force-pushed
the
add-apiserver-watch-metrics
branch
from
e8460f6
to
5eb01db
Compare
|
Added thresholds to the panels to add visual clues for which values are acceptable. |
rfranzke
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area monitoring
/kind enhancement
/priority normal
What this PR does / why we need it:
Add metric shoot:apiserver_watch_duration:quantile. Add dashboard to show length of API Server watches based on resource. These metrics can be helpful in identifying resources with troublesome WATCHES. WATCHES should last a long time so if a resource has many WATCHES that are very short this could point to an issue.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: