Auto-restart scheduler in shoot maintenance #2756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/ops-productivity
|
/invite @timuthy |
danielfoehrKn
approved these changes
Aug 19, 2020
|
We initially stared with restart for cloud-controller-manager, then we did the same for kcm and mcm, now we do it also the kube-scheduler in this PR. This sounds like we bury/workaround issues? Are there occurrences of kube-scheduler Pod which "hangs" for some reason? If yes, shouldn't we rather try to understand the root cause? |
|
@ialidzhikov I don't think there are clear steps to reproduce the problems that we see (luckily very rarely). If you can help here it's highly appreciated to tackle the root cause in the first place, sure, but until then this one-time auto-restart in the maintenance time window is a simply thing to improve the ops experience. |
gardener-robot
added
priority/3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area ops-productivity robustness
/kind enhancement
/priority normal
What this PR does / why we need it:
The
kube-scheduleris now auto-restarted in the shoot maintenance time window, similar to other controllers.Which issue(s) this PR fixes:
Fixes #2722
Special notes for your reviewer:
As #2731 is still in discussion, I'm making this change now separately and rebase the PR later if necessary.
Release note: