Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always allow project admins to manage non-human users #2763

Merged

Conversation

rfranzke
Copy link
Member

How to categorize this PR?

/area user-management
/kind bug
/priority normal

What this PR does / why we need it:
There was a bug that prevented regular project admins from managing non-human users in their Project resources. This PR fixes this issue by consistently removing the owner from the lists (earlier it was only removed from the new member list).

Special notes for your reviewer:
/cc @Diaphteiros @holgerkoser

Release note:

An issue that prevented regular project admins from managing non-human users has been resolved.

Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit 4ca238d into gardener:master Aug 20, 2020
@rfranzke rfranzke deleted the fix/project-non-human-user-management branch August 20, 2020 13:38
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-management User-management related kind/bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants