Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc about Shoot status #2765

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Aug 20, 2020

How to categorize this PR?

/area documentation
/kind task
/priority normal

What this PR does / why we need it:
Add documentation about the Shoot status.

Release note:

A [documentation for the Shoot status](https://github.com/gardener/gardener/blob/master/docs/usage/shoot_status.md) has been added.

Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice doc! Thanks for picking this up ❤️
/lgtm

@timebertt
Copy link
Member

I think this doc also deserves a release note to make end users aware of it (some already asked for such documentation), don't you think 😉

@ialidzhikov
Copy link
Member Author

Very nice doc! Thanks for picking this up ❤️
/lgtm

Thank you for pointing out "kind/documentation" task. I now added a relnote. :)

@timebertt timebertt merged commit c171c2d into gardener:master Aug 21, 2020
Copy link
Member

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two comments, although already merged. Thanks for the nice document!

- `ERR_INFRA_DEPENDENCIES` - indicates that the last error occurred due to dependent objects on the infrastructure level
- `ERR_INFRA_RESOURCES_DEPLETED` - indicates that the last error occurred due to depleted resource in the infrastructure
- `ERR_CLEANUP_CLUSTER_RESOURCES` - indicates that the last error occurred due to resources in the cluster that are stuck in deletion
- `ERR_CONFIGURATION_PROBLEM` - indicates that the last error occurred due a configuration problem
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `ERR_CONFIGURATION_PROBLEM` - indicates that the last error occurred due a configuration problem
- `ERR_CONFIGURATION_PROBLEM` - indicates that the last error occurred due to a configuration problem

| `type` | Name of the condition. |
| `status` | Indicates whether the condition is applicable, with possible values `True`, `False`, `Unknown`, or `Progressing`. |
| `lastTransitionTime` | Timestamp for when the condition last transitioned from one status to another. |
| `lastUpdateTime` | Timestamp for when the condition was updated. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `lastUpdateTime` | Timestamp for when the condition was updated. |
| `lastUpdateTime` | Timestamp for when the condition was updated. Usually changes when `reason` or `message` in condition is updated |

@ialidzhikov ialidzhikov deleted the doc/shoot-status branch August 21, 2020 07:28
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation related kind/task General task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants