Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new dashboard for fluent-bit #2769

Merged
merged 1 commit into from Aug 25, 2020
Merged

Add new dashboard for fluent-bit #2769

merged 1 commit into from Aug 25, 2020

Conversation

Kristian-ZH
Copy link
Contributor

How to categorize this PR?

/area logging
/kind enhancement
/priority normal

What this PR does / why we need it:

  1. Prometheus scrapes metrics from fluent-bit
  2. New dashboard added for fluent-bit.
    Which issue(s) this PR fixes:
    Fixes #

Special notes for your reviewer:
@vpnachev @vlvasilev

Release note:

There is new dashboard for fluent-bit in garden's Grafana

@Kristian-ZH Kristian-ZH requested a review from a team as a code owner August 21, 2020 10:13
@gardener-robot gardener-robot added area/logging Logging related kind/enhancement Enhancement, improvement, extension priority/normal labels Aug 21, 2020
@rfranzke
Copy link
Member

/invite @wyb1 @istvanballok

wyb1
wyb1 suggested changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@wyb1 wyb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Kristian-ZH!
Please provide descriptions in the panels to give some context.

charts/seed-bootstrap/dashboards/fluent-bit-dashboard.json Outdated Show resolved Hide resolved
charts/seed-bootstrap/dashboards/fluent-bit-dashboard.json Outdated Show resolved Hide resolved
charts/seed-bootstrap/dashboards/fluent-bit-dashboard.json Outdated Show resolved Hide resolved
charts/seed-bootstrap/dashboards/fluent-bit-dashboard.json Outdated Show resolved Hide resolved
charts/seed-bootstrap/dashboards/fluent-bit-dashboard.json Outdated Show resolved Hide resolved
@rfranzke
Copy link
Member

/status author-action

@gardener-robot
Copy link

@Kristian-ZH The pull request was assigned to you under author-action. Please unassign yourself when you are done. Thank you.

@Kristian-ZH Kristian-ZH requested a review from wyb1 August 24, 2020 08:38
@Kristian-ZH Kristian-ZH removed their assignment Aug 24, 2020
wyb1
wyb1 reviewed Aug 25, 2020
View reviewed changes
Copy link
Contributor

@wyb1 wyb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment. Other than that looks good!

charts/seed-bootstrap/dashboards/fluent-bit-dashboard.json Outdated Show resolved Hide resolved
@Kristian-ZH Kristian-ZH requested a review from wyb1 August 25, 2020 08:43
wyb1
wyb1 approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@wyb1 wyb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit 1bc0cbb into gardener:master Aug 25, 2020
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyb1 wyb1 wyb1 approved these changes

@rfranzke rfranzke rfranzke approved these changes

@istvanballok istvanballok Awaiting requested review from istvanballok

Assignees
No one assigned
Labels
area/logging Logging related kind/enhancement Enhancement, improvement, extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Kristian-ZH @rfranzke @gardener-robot @wyb1 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3