Vendor k-sigs/controller-runtime@v0.5.10 #2797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/open-source
ialidzhikov
reviewed
Aug 31, 2020
There was a problem hiding this comment.
Thank you for this PR!
I see that with kubernetes-sigs/controller-runtime#1061 there is already an Or predicate. I guess we can now remove our custom or predicate (https://github.com/gardener/gardener/blob/v1.9.0/extensions/pkg/predicate/predicate.go#L92-L123) and use the one from upstream, right?
|
Yes, indeed. Originally I wanted to do it seperately, but now that you also mentioned it, I just did it in this PR. Rather than removing our |
Makes sense. Thanks. |
rfranzke
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area open-source
/kind task
/priority normal
What this PR does / why we need it:
Vendor k-sigs/controller-runtime@v0.5.10, which contains several bug fixes.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
v0.6 will be vendored as part of #2489, see @timuthy's progress.
Release note: