Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VPA to vertical-pod-autoscaler-0.9.0 #3060

Closed
wants to merge 1 commit into from
Closed

Update VPA to vertical-pod-autoscaler-0.9.0 #3060

wants to merge 1 commit into from

Conversation

kallurbsk
Copy link
Contributor

@kallurbsk kallurbsk commented Oct 29, 2020 •
edited

How to categorize this PR?

/area auto-scaling
/area control-plane
/kind enhancement

What this PR does / why we need it:
The PR updates the release of VPA to vpa-pod-autoscaler-0.9.0.
This is an attempt at a version upgrade from 0.8.0 to tackle the issues mentioned in

  1. Allow custom timeout value for webhook calls Allow custom timeout value for webhook calls kubernetes/autoscaler#3549 can help us revert VPA admission controller shouldn't self register mutatingWebhook #2802 while still solving Mutating webhook doesn't abide by the failurePolicy of Ignore and blocks further pod creation #2779 by a simple change to the webhook timeout config in the charts.
  2. VPA - Always process OOM samples VPA - Always process OOM samples kubernetes/autoscaler#3079 can address etcd-druid Pod is not scaled up despite being OOMKilled #2890 by reacting better to oomkills.
  3. CLI flags for VPA recommender aggregations config CLI flags for VPA recommender aggregations config. kubernetes/autoscaler#2905 can help us configure VPA to scale down recommendations faster than 24h (perhaps as quickly as after 2h). That was the rationale behind this PR in the first place. But aggressive scale downs will only exacerbate the spike-handling problem we have been increasingly facing with the VPA recommender. Perhaps we should go a bit slow on this one.

Which issue(s) this PR fixes:
Fixes #2961

Special notes for your reviewer:

Release note:

Update the VPA pod autoscaler version from 0.8.0 to 0.9.0

@kallurbsk kallurbsk requested a review from a team as a code owner October 29, 2020 06:15
@CLAassistant
Copy link

CLAassistant commented Oct 29, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@gardener-robot
Copy link

@kallurbsk Labels area/todo, kind/todo do not exist.

@gardener-robot gardener-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 29, 2020
@rfranzke
Copy link
Member

Please update the PR title, description, labels, and, if necessary, the release note.

@rfranzke
Copy link
Member

Also, please squash the commits and sign the CLA.

@kallurbsk kallurbsk changed the title Fix2961 Update VPA to vertical-pod-autoscaler-0.9.0 Oct 29, 2020
@gardener-robot gardener-robot added area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension labels Oct 29, 2020
@kallurbsk
Copy link
Contributor Author

Hi Rafael,

Tried updating the CLA but the link is dying on me. Updated other details.
I am trying to squash the commits now.

@kallurbsk
Fix for 2961 : Update VPA images from 0.8.0 to 0.9.0
af2f7f1 
The commit updates vpa-recommender, vpa-updater and
vpa-admission-controller from 0.8.0 to 0.9.0

Add minAllowed for kcm VPA

Release v1.12.0

Prepare Next Dev Cycle v1.13.0-dev

Fix node-exporter configuration

* Use default values for ignored fs types.
* Fix ignored mount points
* Simplify mountpoints

On an xfs filesystem the reported size of the root volume was incorrect. This
change fixes this issue.

Co-authored-by: wyb1 <wesley.bermbach@sap.com>
Co-authored-by: Istvan Zoltan Ballok <istvan.zoltan.ballok@sap.com>

Allow again some seed taints to be used

Reference in CONTRIBUTING.md to the Contributor Guide on gardener.cloud

Signed-off-by: Christian Berendt <berendt@23technologies.cloud>

Default kubelet.kubeReserved.pid only for k8s >= 1.15

Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@kallurbsk kallurbsk requested a review from a team as a code owner October 29, 2020 08:15
@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 29, 2020
@amshuman-kr
Copy link

/hold Until commits are fixed.

@kallurbsk kallurbsk closed this Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related area/control-plane Control plane related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update VPA to vertical-pod-autoscaler-0.9.0
8 participants
@kallurbsk @CLAassistant @gardener-robot @rfranzke @amshuman-kr @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3