Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.12] Cherry-pick - Add KEEP_ALIVE to apiserver-proxy #3093

Conversation

mvladev
Copy link

@mvladev mvladev commented Nov 3, 2020

How to categorize this PR?

/area networking
/kind bug
/priority normal

What this PR does / why we need it:

Some upstream LoadBalancers have low idle connection timeouts and reset the connection. For AWS NLBs its 350sec (unconfigurable).

If a controller is watching the API server via the proxy, AWS NLB might simply silently terminate the connection if no data is send between the client and the API server.

Which issue(s) this PR fixes:

n/a

Special notes for your reviewer:

PR in master #3092

Release note:

`apiserver-proxy` now uses tcp keepalive every 55 seconds to prevent idle timeouts between it and the SNI LoadBalancer.

Some upstream LoadBalancers have low idle connection timeouts and reset
the connection. For AWS NLBs its 350sec (unconfigurable).

If a controller is watching the API server via the proxy, AWS NLB might
simply silently terminate the connection if no data is send between the
client and the API server
@mvladev mvladev requested a review from a team as a code owner November 3, 2020 08:12
@gardener-robot gardener-robot added area/networking Networking related kind/bug Bug priority/normal size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 3, 2020
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit dc857fd into gardener:release-v1.12 Nov 3, 2020
@mvladev mvladev deleted the apiserver-proxy-keep-alive-release-v1.12 branch November 3, 2020 15:38
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking Networking related kind/bug Bug size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants