[release-1.12] Cherry-pick Set KEEPALIVE on istio-ingress-gateway listeners #3105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some LoadBalancers do not set KEEPALIVE when they open a TCP connection to the Istio Ingress Gateway. For long living connections it can cause silent timeouts. Therefore envoy must be configured to send KEEPALIVE to downstream (LB). See envoyproxy/envoy#3634
gardener-robot
added
area/networking
mvladev
deleted the
istio-ingress-gateway-downstream-keep-alive-release-v1.12
branch
gardener-robot
added
priority/3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area networking
/kind bug
/priority normal
What this PR does / why we need it:
Some LoadBalancers (AWS NLB) do not set KEEPALIVE when they open a TCP connection to the Istio Ingress Gateway. For long living connections it can cause silent timeouts when idle timeouts are hit.
Therefore envoy must be configured to send KEEPALIVE to downstream (LB).
See envoyproxy/envoy#3634
Which issue(s) this PR fixes:
n/a
Special notes for your reviewer:
Cherry-pick of #3104
Release note: