Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.12] Cherry-pick Fix coredns network policies. #3163

Merged

Conversation

mvladev
Copy link

@mvladev mvladev commented Nov 16, 2020

How to categorize this PR?

/area neworking
/kind bug
/priority normal

What this PR does / why we need it:

Now they allow traffic from the Pod network. This is needed because traffic might come from the calico tunnel IP which is part of the Pod network.

Before this, Pods with hostNetwork: true and dnsPolicy: ClusterFirstWithHostNet could not talk to coredns if they are running on a different Node than CoreDNS.

Which issue(s) this PR fixes:
n/a

Special notes for your reviewer:

Cherry-pick of #3162

Release note:

Fixed NetworkPolicy `gardener.cloud--allow-dns` to allow traffic from Pods with `hostNetwork: true` and `dnsPolicy: ClusterFirstWithHostNet`. 

Now they allow traffic from the Pod network. This is needed because
traffic might come from the calico tunnel IP which is part of the Pod
network.

Before this, Pods with `hostNetwork: true` and `dnsPolicy: ClusterFirstWithHostNet`
could not talk to coredns if they are running on a different Node than
CoreDNS.
@mvladev mvladev requested a review from a team as a code owner November 16, 2020 07:55
@gardener-robot
Copy link

@mvladev Label area/neworking does not exist.

@mvladev
Copy link
Author

mvladev commented Nov 16, 2020

/assign @schrodit

Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit 77cf1c7 into gardener:release-v1.12 Nov 16, 2020
@mvladev mvladev deleted the fix-coredns-hostnet-release-v1.12 branch November 16, 2020 10:54
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Bug size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants