Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support containerd sandbox image overwrite #3182

Merged
merged 2 commits into from
Nov 18, 2020
Merged

Support containerd sandbox image overwrite #3182

merged 2 commits into from
Nov 18, 2020

Conversation

jia-jerry
Copy link
Contributor

How to categorize this PR?

/area os
/kind enhancement
/priority blocker

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #3161

Special notes for your reviewer:
I removed --pod-infra-container-image option for kubelet. It is not needed when --container-runtime=remote. https://github.com/kubernetes/kubernetes/blob/master/cmd/kubelet/app/server.go#L190
Release note:

Containerd is supported in regions where gcr.io container registry can't be accessed.

@jia-jerry jia-jerry requested a review from a team as a code owner November 18, 2020 05:11
@gardener-robot gardener-robot added area/os Operator system related kind/enhancement Enhancement, improvement, extension priority/blocker size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2020
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit cc72fd0 into gardener:release-v1.12 Nov 18, 2020
@jia-jerry jia-jerry deleted the containerd-config branch January 19, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/os Operator system related kind/enhancement Enhancement, improvement, extension size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants