Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup some deprecated helper funcs #3463

Merged
merged 5 commits into from Jan 28, 2021
Merged

Cleanup some deprecated helper funcs #3463

merged 5 commits into from Jan 28, 2021

Conversation

timebertt
Copy link
Member

How to categorize this PR?

/kind cleanup
/priority normal

What this PR does / why we need it:

Cleanup some deprecated / duplicated helper funcs.

Which issue(s) this PR fixes:
Part of #3109

Special notes for your reviewer:
/squash

Release note:

Several deprecated / duplicated helper funcs were removed:
- `kutils.KeyFromObject` in favor of `client.ObjectKeyFromObject`
- `controllerutils.HasFinalizer` in favor of `controllerutil.ContainsFinalizer`
- `extensionscontroller.HasFinalizer` in favor of `controllerutil.ContainsFinalizer`
- `controllerutils.BoolPtrDerefOr` in favor of `pointer.BoolPtrDerefOr`
- `flow.SimpleTaskFn`

@timebertt timebertt requested a review from a team as a code owner January 27, 2021 09:12
@gardener-robot gardener-robot added needs/review kind/cleanup Something that is not needed anymore and can be cleaned up size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 27, 2021
@timebertt timebertt mentioned this pull request Jan 27, 2021
Closed
timuthy
timuthy approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke
Copy link
Member

/hold until v1.16 is released if you agree

@rfranzke
Copy link
Member

/unhold

@rfranzke rfranzke merged commit a1b0891 into gardener:master Jan 28, 2021
@timebertt timebertt deleted the cleanup/helper-funcs branch January 28, 2021 08:33
krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
@timebertt
Cleanup some deprecated helper funcs (gardener#3463)
541098b 
* Remove kutils.KeyFromObject in favor of client.ObjectKeyFromObject

* Remove deprecated SimpleTaskFn

* Remove controllerutils.HasFinalizer in favor of controllerutil.ContainsFinalizer

* Remove controllerutils.BoolPtrDerefOr in favor of pointer.BoolPtrDerefOr

* Remove extensionscontroller.HasFinalizer in favor of controllerutil.ContainsFinalizer
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
@timebertt
Cleanup some deprecated helper funcs (gardener#3463)
6d35e83 
* Remove kutils.KeyFromObject in favor of client.ObjectKeyFromObject

* Remove deprecated SimpleTaskFn

* Remove controllerutils.HasFinalizer in favor of controllerutil.ContainsFinalizer

* Remove controllerutils.BoolPtrDerefOr in favor of pointer.BoolPtrDerefOr

* Remove extensionscontroller.HasFinalizer in favor of controllerutil.ContainsFinalizer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

@timuthy timuthy timuthy approved these changes

Assignees
No one assigned
Labels
kind/cleanup Something that is not needed anymore and can be cleaned up size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@timebertt @rfranzke @timuthy @gardener-robot-ci-2 @gardener-robot