Cleanup of runtime.Object and meta.Accessor #3476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
kind/api-change
|
❤️ all these cleanup PRs! |
|
/squash |
rfranzke
approved these changes
Jan 29, 2021
ezeeyahoo
pushed a commit
to ezeeyahoo/gardener
that referenced
this pull request
Feb 17, 2021
gardener-robot
added
priority/3
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind cleanup
/priority normal
What this PR does / why we need it:
With
controller-runtime@v0.7there areclient.Objectandclient.ObjectListto distinguish between single API objects and object lists.c-r has replaced their usage of
runtime.Object(which is more generic) by those two interfaces to have a clearer func/interface contract of what implementations expect from passed objects.I followed up on this and cleaned up our usage of
runtime.Objectas well and replaced it withclient.{Object,ObjectList}wherever applicable.Though, there are still a lot of
runtime.Objectusages left, e.g. in API and registry packages, which have to comply with other interfaces expectingruntime.Object.Also some of our helper funcs are generic and accept a single object as well as an object list, so for those cases
runtime.Objectis also still needed.I think I cut it down to the bare minimum now.
I also cleaned up some unnecessary usages of
meta.Accessorin favor ofclient.Objectwhere it is helpful and makes code a bit slimmer.Which issue(s) this PR fixes:
Part of #3109
Special notes for your reviewer:
/squash
Release note: