Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #3691: Fix istio scaling #3694

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Automated cherry pick of #3691: Fix istio scaling #3694

merged 1 commit into from
Mar 11, 2021

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Mar 11, 2021 •
edited

Cherry pick of #3691 on release-v1.16.

#3691: Fix istio scaling

Release note:

The `istiod` deployment in the `istio-system` namespace now has replicas set to 2 and can be properly scaled by its corresponding VPA.

Added resource requests and limits to the `apiserver-proxy-pod-mutator` container which should allow the corresponding HPA to properly read CPU metrics from the `kube-apiserver` when SNI is enabled.

@ialidzhikov ialidzhikov requested a review from a team as a code owner March 11, 2021 16:43
@gardener-robot gardener-robot added needs/review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2021
vpnachev
vpnachev approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vpnachev vpnachev merged commit ff56f8c into gardener:release-v1.16 Mar 11, 2021
@ialidzhikov ialidzhikov deleted the automated-cherry-pick-of-#3691-upstream-release-v1.16 branch October 22, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpnachev vpnachev vpnachev approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ialidzhikov @vpnachev @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot @plkokanov