Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.20] Automated cherry pick of #3863: set realms annotation for non-internal DNSProviders #3864

Merged
merged 1 commit into from Apr 12, 2021
Merged

[release-v1.20] Automated cherry pick of #3863: set realms annotation for non-internal DNSProviders #3864

merged 1 commit into from Apr 12, 2021

Conversation

timuthy
Copy link
Contributor

@timuthy timuthy commented Apr 12, 2021 •
edited by ialidzhikov

/kind bug
/kind regression

Cherry pick of #3863 on release-v1.20.

#3863: set realms annotation for non-internal DNSProviders

Release Notes:

An issue has been fixed which prevented DNS entries being created correctly. Only requests coming from shoot clusters were affected.

@MartinWeindel @mandelsoft @timuthy
set realms annotation for non-internal DNSProviders
2e56510 
Co-authored-by: Uwe Krueger <uwe.krueger@sap.com>
@timuthy timuthy requested a review from a team as a code owner April 12, 2021 12:50
@gardener-robot gardener-robot added needs/review size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 12, 2021
@gardener-robot gardener-robot added kind/bug Bug kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution labels Apr 12, 2021
ialidzhikov
ialidzhikov approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ialidzhikov ialidzhikov merged commit 638508c into gardener:release-v1.20 Apr 12, 2021
@timuthy timuthy deleted the automated-cherry-pick-of-#3863-upstream-release-v1.20 branch April 12, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

Assignees
No one assigned
Labels
kind/bug Bug kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@timuthy @ialidzhikov @gardener-robot-ci-2 @gardener-robot @MartinWeindel