Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Resource "ShootExtensionStatus" in core.gardener.cloud #3878

Merged
merged 2 commits into from
May 5, 2021
Merged

Add Resource "ShootExtensionStatus" in core.gardener.cloud #3878

merged 2 commits into from
May 5, 2021

Conversation

danielfoehrKn
Copy link
Contributor

@danielfoehrKn danielfoehrKn commented Apr 13, 2021 •
edited by rfranzke

**How to categorize this PR?**

/area quality
/kind enhancement

What this PR does / why we need it:

Adds a new resource in the core.gardener.cloud resource group with the name ShootExtensionStatus.
This resource is intended to hold the information of the ProviderStatus field from multiple Gardener Extension resources.

It is modeled after the ShootState resource. Hence, there is only a Spec (not Status), as no spec is actually reconciled.

Which issue(s) this PR fixes:
Part of #3873

Special notes for your reviewer:

This PR only contains the type definitions & client generations.

Release note:

Add the resource `ShootExtensionStatus` to the resource group `core.gardener.cloud` which is intended to hold the information of the `ProviderStatus` field from multiple Gardener Extension resources from the Seed cluster.

@danielfoehrKn danielfoehrKn requested a review from a team as a code owner April 13, 2021 15:39
@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 13, 2021
timuthy
timuthy requested changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you also want to include necessary storage changes for pkg/registry/core?

pkg/apis/core/v1beta1/types_shootproviderstate.go Outdated Show resolved Hide resolved
pkg/apis/core/types_shootproviderstate.go Outdated Show resolved Hide resolved
@rfranzke
Copy link
Member

What about calling the resource ShootExtensionStatus instead? Two rationales, first is to not "restrict" it to provider extensions (there might be other extensions like networking or what not that might produce some status), second is to not confuse it with the "state" which is used for control plane migration (also, in the extensions.gardener.cloud APIs the fields are called .status.state vs. status.providerStatus).

rfranzke
rfranzke reviewed Apr 14, 2021
View reviewed changes
pkg/apis/core/types_shootproviderstate.go Outdated Show resolved Hide resolved
pkg/apis/core/types_shootproviderstate.go Outdated Show resolved Hide resolved
@danielfoehrKn
Copy link
Contributor Author

danielfoehrKn commented Apr 14, 2021 •
edited

I added validation and storage implementation in a second commit.

I am a bit torn between naming the plural of the resource "shootextensionstatus" or "shootextensionstatus" - see here. On the one hand, statuses seems to be the right plural for status.
Suggestions welcome.

EDIT: plural being used is "shootextensionstatuses"

@danielfoehrKn danielfoehrKn changed the title Add Resource "ShootProviderState" in core.gardener.cloud Add Resource "ShootExtensionStatus" in core.gardener.cloud Apr 14, 2021
@gardener-robot
Copy link

@danielfoehrKn The pull request was assigned to you under author-action. Please unassign yourself when you are done. Thank you.

@danielfoehrKn danielfoehrKn force-pushed the quality/extension-status-sync branch from b483cb6 to 5093f61 Compare May 3, 2021 08:46
@rfranzke
Copy link
Member

rfranzke commented May 3, 2021

/needs rebase

@danielfoehrKn danielfoehrKn force-pushed the quality/extension-status-sync branch from 5093f61 to 63a571f Compare May 5, 2021 08:34
rfranzke
rfranzke approved these changes May 5, 2021
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@timuthy - any final opinions?

timuthy
timuthy approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thank you

@timuthy timuthy merged commit 306623c into gardener:master May 5, 2021
krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
@danielfoehrKn
Add Resource "ShootExtensionStatus" in core.gardener.cloud (gardener#…
81252d0 
…3878)

* Add ShootExtensionStatus in core.gardener.cloud/v1alpha1

* Add Gardener APIServer storage configuration for ShootExtensionStatus
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
@danielfoehrKn
Add Resource "ShootExtensionStatus" in core.gardener.cloud (gardener#…
c290186 
…3878)

* Add ShootExtensionStatus in core.gardener.cloud/v1alpha1

* Add Gardener APIServer storage configuration for ShootExtensionStatus
@ebensom ebensom mentioned this pull request Sep 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

@timuthy timuthy timuthy approved these changes

Assignees

@danielfoehrKn danielfoehrKn

Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@danielfoehrKn @rfranzke @gardener-robot @timuthy @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3