Fix handling of aggregate-prometheus resources with hvpa #3998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/monitoring
timuthy
reviewed
May 5, 2021
wyb1
force-pushed
the
fix-aggregate-prometheus-hvpa
branch
from
8ee64af
to
5e0f771
Compare
|
@wyb1 The pull request was assigned to you under |
amshuman-kr
suggested changes
May 6, 2021
There was a problem hiding this comment.
@wyb1 I think there is still a problem with the resources rendered rightly for aggregated-prometheus. Please see my comments below.
wyb1
force-pushed
the
fix-aggregate-prometheus-hvpa
branch
from
5e0f771
to
62b1819
Compare
|
/assign @amshuman-kr |
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area monitoring
/kind bug
What this PR does / why we need it:
Fix an issue where the gardenlet overwrites changes from
hvpafor theaggregate-prometheus.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/cc @amshuman-kr
Release note: