Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unknown label area/operations from the templates #4013

Merged
merged 1 commit into from
May 10, 2021

Conversation

vpnachev
Copy link
Member

How to categorize this PR?

/area dev-productivity
/kind cleanup

What this PR does / why we need it:
Remove the unknown label area/operations from the templates

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The unknown github label `area/operations` has been removed from the github issues templates.

@vpnachev vpnachev requested a review from a team as a code owner May 10, 2021 12:17
@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) kind/cleanup Something that is not needed anymore and can be cleaned up needs/review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 10, 2021
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Can you remove the release note, please?

@vpnachev
Copy link
Member Author

Why? I have added it on purpose. This label is set in all extensions and it would be nice extension owners to be aware about such change.

@rfranzke
Copy link
Member

Well, I would not pollute the (already long/large) release note with minor things not relevant to anybody. Nobody will notice or even care whether one of many different labels were added or removed from the GitHub templates. 😃

@vpnachev
Copy link
Member Author

As we have different target groups and it is already set to developer, adding yet another short line release note to the long list will not hurt 😄 so I will not remove it.

@vpnachev vpnachev merged commit 623cd78 into gardener:master May 10, 2021
@vpnachev vpnachev deleted the dev/remove-unknown-label branch May 10, 2021 12:56
krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev-productivity Developer productivity related (how to improve development) kind/cleanup Something that is not needed anymore and can be cleaned up size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants