Increase limits for metrics-server. #4017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/auto-scaling
|
@amshuman-kr You have mentioned internal references in the public. Please check. |
|
/assign |
|
@amshuman-kr You have mentioned internal references in the public. Please check. |
vpnachev
reviewed
May 10, 2021
pkg/operation/botanist/component/metricsserver/metrics_server.go
Outdated
Show resolved
Hide resolved
amshuman-kr
force-pushed
the
increase-metrics-server-limits
branch
from
3a44df8
to
85699f9
Compare
|
@vpnachev I have set the limits to |
vpnachev
suggested changes
May 11, 2021
amshuman-kr
force-pushed
the
increase-metrics-server-limits
branch
from
85699f9
to
b1506af
Compare
|
@vpnachev I have renamed the variables as you suggested. Can you PTAL? |
rfranzke
approved these changes
May 11, 2021
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane auto-scaling
/kind post-mortem
What this PR does / why we need it:
Increase limits for metrics-server. This is a temporary fix until we have non-circular auto-scaling for metrics-server.
Which issue(s) this PR fixes:
Fixes #
https://github.tools.sap/kubernetes-live/issues-live/issues/453#issuecomment-213566
Special notes for your reviewer:
Follow up issue after this PR goes in -> #4018
cc @timuthy @schrodit @tedteng @dguendisch @vlerenc
Release note: