Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Gardener admins to access csrs #4059

Merged
merged 1 commit into from
May 17, 2021
Merged

Allow Gardener admins to access csrs #4059

merged 1 commit into from
May 17, 2021

Conversation

ialidzhikov
Copy link
Member

/area security ops-productivity
/kind enhancement

$ k get csr -A
Error from server (Forbidden): certificatesigningrequests.certificates.k8s.io is forbidden: User "some.admin@gardener.cloud" cannot list resource "certificatesigningrequests" in API group "certificates.k8s.io" at the cluster scope

Release note:

Gardener administrators are now allowed to access certificatesigningrequests.

@ialidzhikov
Allow Gardener admins to access csrs
e473efb 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov ialidzhikov requested a review from a team as a code owner May 14, 2021 09:37
@gardener-robot gardener-robot added area/ops-productivity Operator productivity related (how to improve operations) area/security Security related kind/enhancement Enhancement, improvement, extension needs/review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 14, 2021
@ialidzhikov ialidzhikov added this to the v1.23 milestone May 14, 2021
vpnachev
vpnachev approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

charts/gardener/controlplane/charts/application/templates/rbac-user.yaml Show resolved Hide resolved
@ialidzhikov ialidzhikov merged commit 41cfe1d into gardener:master May 17, 2021
@ialidzhikov ialidzhikov deleted the enh/rbac-for-csrs branch May 23, 2021 17:21
krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
@ialidzhikov
Allow Gardener admins to access csrs (gardener#4059)
ceec6ba 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
@ialidzhikov
Allow Gardener admins to access csrs (gardener#4059)
2d21aeb 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpnachev vpnachev vpnachev approved these changes

@mvladev mvladev Awaiting requested review from mvladev

Assignees
No one assigned
Labels
area/ops-productivity Operator productivity related (how to improve operations) area/security Security related kind/enhancement Enhancement, improvement, extension size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ialidzhikov @vpnachev @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot