Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ManagedSeed update / deletion issue on soil clusters #4070

Merged

Conversation

stoyanr
Copy link
Contributor

@stoyanr stoyanr commented May 17, 2021

How to categorize this PR?

/area control-plane
/kind bug

What this PR does / why we need it:
Fixes the ManagedSeed update / deletion issue on soil clusters described in #3890, #4002.

Which issue(s) this PR fixes:
Fixes #3890
Fixes #4002

Special notes for your reviewer:

Release note:

Fixed an issue that prevented the update and deletion of managed seeds on soil clusters.

@stoyanr stoyanr requested a review from a team as a code owner May 17, 2021 15:17
@gardener-robot gardener-robot added area/control-plane Control plane related kind/bug Bug needs/review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 17, 2021
@stoyanr
Copy link
Contributor Author

stoyanr commented May 17, 2021

/cc @timebertt

@Diaphteiros I tested this locally, let's validate it on your test landscape as well before merging.

Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

for second opinion
/invite @timebertt

@ialidzhikov ialidzhikov added this to the v1.23 milestone May 18, 2021
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@timebertt timebertt merged commit 28234df into gardener:master May 18, 2021
@stoyanr stoyanr deleted the fix-managed-seed-deletion-on-soil-clusters branch May 18, 2021 09:23
@ialidzhikov
Copy link
Member

@stoyanr , can you file cherry-picks against release-v1.22, release-v1.21 and release-v1.20 branches?
It would be nice to backport this fix as we had 2 issue reports for older versions (v1.20.x and v1.18.x)?

@stoyanr
Copy link
Contributor Author

stoyanr commented May 19, 2021

@ialidzhikov Done, see above. BTW, @Diaphteiros tested the fix on his local soil setup and confirmed that it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Control plane related kind/bug Bug size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
6 participants