Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release milestone check #4085

Merged
merged 1 commit into from
May 25, 2021
Merged

Conversation

rfranzke
Copy link
Member

How to categorize this PR?

/area dev-productivity
/kind enhancement

What this PR does / why we need it:
With this PR, when a milestone for the next minor version exists, PRs are only mergeable if they are assigned to this milestone. Otherwise, the merge will be blocked.
This will help the developers who are currently in the release validation phase to prevent unexpected PR merges to master.

Special notes for your reviewer:
/cc @ialidzhikov @timebertt

Release note:

If a milestone for the next minor version exists then PRs to the `master` branch are only mergeable if they are assigned to this milestone.

@rfranzke rfranzke requested a review from a team as a code owner May 20, 2021 15:47
@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension needs/review size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 20, 2021
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, love it!

.github/workflows/release-milestone.yaml Show resolved Hide resolved
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@timebertt timebertt merged commit 800dde5 into gardener:master May 25, 2021
@rfranzke rfranzke deleted the enh/milestone branch May 25, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants