Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ControllerRegistration .spec.resources[].type to be Bastion #4090

Merged
merged 1 commit into from
May 21, 2021
Merged

Allow ControllerRegistration .spec.resources[].type to be Bastion #4090

merged 1 commit into from
May 21, 2021

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented May 21, 2021 •
edited

/kind bug

Currently trying to apply provider-aws ControllerRegistration with Bastion fails with:

$ k apply -f https://raw.githubusercontent.com/gardener/gardener-extension-provider-aws/67201b176e1460d5a51f44ada0e58011bd120536/example/controller-registration.yaml
The ControllerRegistration "provider-aws" is invalid: spec.resources[2].kind: Unsupported value: "Bastion": supported values: "BackupEntry", "DNSProvider", "Extension", "Infrastructure", "Network", "OperatingSystemConfig", "Worker", "BackupBucket", "ContainerRuntime", "ControlPlane"

Release note:

The Gardener API server now allows `Bastion` to be specified for ControllerRegistration `.spec.resources[].type`.

@ialidzhikov ialidzhikov requested a review from a team as a code owner May 21, 2021 07:03
@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion kind/bug Bug size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 21, 2021
@ialidzhikov
Allow ControllerRegistration .spec.resources[].type to be Bastion
33dbb00 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov ialidzhikov changed the title "Allow ControllerRegistration .spec.resources[].type to be Bastion Allow ControllerRegistration .spec.resources[].type to be Bastion May 21, 2021
@ialidzhikov
Copy link
Member Author

/invite @petersutter

vpnachev
vpnachev approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/needs second-opinion

@ialidzhikov ialidzhikov mentioned this pull request May 21, 2021
Merged
@ialidzhikov ialidzhikov mentioned this pull request May 21, 2021
Merged
@ialidzhikov ialidzhikov merged commit a14c674 into gardener:master May 21, 2021
@ialidzhikov ialidzhikov deleted the fix/allow-bastions branch May 21, 2021 08:19
@petersutter
Copy link
Contributor

thanks @ialidzhikov

krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
@ialidzhikov
Allow ControllerRegistration .spec.resources[].type to be Bastion (…
1b9b376 
…gardener#4090)

Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
@ialidzhikov
Allow ControllerRegistration .spec.resources[].type to be Bastion (…
7ad5fd9 
…gardener#4090)

Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpnachev vpnachev vpnachev approved these changes

@rfranzke rfranzke rfranzke approved these changes

@petersutter petersutter Awaiting requested review from petersutter

Assignees
No one assigned
Labels
kind/api-change API change with impact on API users kind/bug Bug size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ialidzhikov @petersutter @vpnachev @rfranzke @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot